Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix child-process-uid-gid on Windows #8924

Closed
wants to merge 1 commit into from
Closed

test: fix child-process-uid-gid on Windows #8924

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 4, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The process.getuid method does not exist on this platform.

Ref: #8864

@targos
test: fix child-process-uid-gid on Windows
ec7121c 
The process.getuid method does not exist on this platform.

Ref: #8864
@targos targos added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Oct 4, 2016
@targos targos mentioned this pull request Oct 4, 2016
Closed
2 tasks
@targos
Copy link
Member Author

targos commented Oct 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4375/

lpinca
lpinca approved these changes Oct 4, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 4, 2016
cjihrig
cjihrig approved these changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should fast track this.

@targos
Copy link
Member Author

targos commented Oct 4, 2016

I agree. Feel free to land it as I'm not on my dev computer.

@geek
Copy link
Member

geek commented Oct 4, 2016

LGTM

@Trott Trott mentioned this pull request Oct 4, 2016
Closed
4 tasks
Trott
Trott approved these changes Oct 4, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and definitely agree on the fast-tracking.

@Trott Trott self-assigned this Oct 4, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 4, 2016
@targos @Trott
test: fix child-process-uid-gid on Windows
1554735 
The process.getuid method does not exist on this platform.

Ref: nodejs#8864
PR-URL: nodejs#8924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 4, 2016

Landed in 1554735

@Trott Trott closed this Oct 4, 2016
@addaleax addaleax deleted the fix-8864-win branch October 5, 2016 15:02
@addaleax addaleax mentioned this pull request Oct 5, 2016
Closed
2 tasks
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@targos @jasnell
test: fix child-process-uid-gid on Windows
4d31206 
The process.getuid method does not exist on this platform.

Ref: #8864
PR-URL: #8924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@targos @Fishrock123
test: fix child-process-uid-gid on Windows
2f0f596 
The process.getuid method does not exist on this platform.

Ref: #8864
PR-URL: #8924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees

@Trott Trott

Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @geek @Trott @lpinca @cjihrig @mscdex @MylesBorins