Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: persist net.Socket options before connect #880

Closed
wants to merge 15 commits into from

Commits on Apr 17, 2015

  1. Working on v2.0.0

    chrisdickinson committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    e61ee49 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2015

  1. doc: update CONTRIBUTING.md

    This commit:
      - fixes development branch (v1.x -> master)
      - updates stability index wording
      - use iojs binary instead of node
    
    PR-URL: nodejs#1466
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6870764 View commit details
    Browse the repository at this point in the history
  2. Revert "http: don't bother making a copy of the options"

    This reverts commit 06cfff9.
    
    Reverted because it introduced a regression where (because options were
    modified in the later functionality) options.host and options.port would
    be overridden with values provided in other, supported ways.
    
    PR-URL: nodejs#1467
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    5 Configuration menu
    Copy the full SHA
    7180597 View commit details
    Browse the repository at this point in the history
  3. test: add test for 06cfff9 regression

    This commit adds a test to ensure all options are NOT modified after
    passing them to http.request. Specifically options.host and options.port
    are the most prominent that would previously error, but add the other
    options that have default values.
    
    options.host and options.port were overridden for the one-argument
    net.createConnection(options) call.
    
    PR-URL: nodejs#1467
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6bf85bc View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2015

  1. Merge v1.8.1.

    This brings in the '%PYTHON%' revert, and restores
    the correct NODE_MODULE_VERSION.
    
    PR-URL: nodejs#1482
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    chrisdickinson committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    59a5c98 View commit details
    Browse the repository at this point in the history
  2. doc: update AUTHORS list

    Update AUTHORS list using tools/update-authors.sh
    
    PR-URL: nodejs#1476
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    rvagg committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    2632775 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2015

  1. doc: add spaces to child.kill example

    PR-URL: nodejs#1503
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    enaqx authored and brendanashworth committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    b16a328 View commit details
    Browse the repository at this point in the history
  2. doc: add Fishrock123 to the TC

    as per nodejs#1502
    
    PR-URL: nodejs#1507
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Fishrock123 committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    22aafa5 View commit details
    Browse the repository at this point in the history
  3. tls_wrap: use localhost if options.host is empty

    tls.connect(options) with no options.host should accept a certificate
    with CN: 'localhost'. Fix Error: Hostname/IP doesn't match
    certificate's altnames: "Host: undefined. is not cert's CN: localhost"
    
    'localhost' is not added directly to defaults because that is not
    always desired (for example, when using options.socket)
    
    PR-URL: nodejs#1493
    Fixes: nodejs#1489
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    sitegui authored and silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    a7d7463 View commit details
    Browse the repository at this point in the history
  4. module: remove '' from Module.globalPaths

    If `$NODE_PATH` contains trailing separators, `Module.globalPaths` will
    contains empty strings. When `Module` try to resolve a module's path,
    `path.resolve('', 'index.js')` will boil down to `$PWD/index.js`, which
    makes sub modules can access global modules and get unexpected result.
    
    PR-URL: nodejs#1488
    Reviewed-By: Roman Reiss <me@silverwind.io>
    chrisyip authored and silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    7384ca8 View commit details
    Browse the repository at this point in the history
  5. doc: update branch to master

    Update the remaining markdown files to refer to the master branch.
    PR-URL: nodejs#1511
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    silverwind committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    bb254b5 View commit details
    Browse the repository at this point in the history
  6. buffer: little improve for Buffer.concat method

    When buffer list less than 2, no need to calculate the length.
    The change's benchmark result is here:
    https://gist.github.com/JacksonTian/2c9e2bdec00018e010e6
    It improve 15% ~ 25% speed when list only have one buffer,
    to other cases no effect.
    
    PR-URL: nodejs#1437
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    JacksonTian authored and brendanashworth committed Apr 23, 2015
    Configuration menu
    Copy the full SHA
    3d3083b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2015

  1. net: cleanup connect logic

    Separates out the lookup logic for net.Socket. In the event
    the `host` property is an IP address, the lookup is skipped.
    
    PR-URL: nodejs#1505
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
    evanlucas committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    1bef717 View commit details
    Browse the repository at this point in the history
  2. net: add lookup option to Socket.prototype.connect

    Allows customization of the lookup function used when
    Socket.prototype.connect is called using a hostname.
    
    PR-URL: nodejs#1505
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
    evanlucas committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    4abe2fa View commit details
    Browse the repository at this point in the history
  3. net: persist net.Socket options before connect

    Remembers net.Socket options called before connect and retroactively
    applies them after the handle has been created.
    
    This change makes the following function calls more user-friendly:
    
    - setKeepAlive()
    - setNoDelay()
    - ref()
    - unref()
    
    Related: nodejs/node-v0.x-archive#7077 and
    nodejs/node-v0.x-archive#8572
    evanlucas committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    102a993 View commit details
    Browse the repository at this point in the history