Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding test for _stream.writable ended state #8778

Closed
wants to merge 1 commit into from
Closed

adding test for _stream.writable ended state #8778

wants to merge 1 commit into from

Conversation

italoacasas
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Adding tests for stream._writableState.ended

Issue related: #8686

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 26, 2016
@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Sep 26, 2016
@mcollina mcollina self-assigned this Sep 26, 2016
jasnell
jasnell reviewed Sep 27, 2016
View reviewed changes
test/parallel/test-stream-writable-ended-state.js

assert.strictEqual(writable._writableState.ended, false);

writable.end('testing ended state', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback here should be wrapped in a common.mustCall() in order to verify that it actually does get called.

@mcollina
Copy link
Member

LGTM

jasnell
jasnell approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jasnell
Copy link
Member

jasnell commented Sep 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4331/

mcollina pushed a commit that referenced this pull request Sep 30, 2016
@italoacasas @mcollina
test: stream writable ended state
5e6bd84 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mcollina
Copy link
Member

CI failures were not related.
Landed in 5e6bd84

@mcollina mcollina closed this Sep 30, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@italoacasas @jasnell
test: stream writable ended state
2ecd3b5 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 6, 2016
@italoacasas
test: stream writable ended state
89f2221 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@italoacasas
test: stream writable ended state
81e60f4 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@italoacasas @Fishrock123
test: stream writable ended state
4fa0fc5 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@italoacasas @rvagg
test: stream writable ended state
5e5d034 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@italoacasas @MylesBorins
test: stream writable ended state
c543f4a 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

@mcollina mcollina

Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@italoacasas @mcollina @jasnell @mscdex @MylesBorins @nodejs-github-bot