Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding danbev to collaborators #8359

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Aug 31, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

adding danbev to collaborators

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 31, 2016
@danbev
Copy link
Contributor Author

danbev commented Aug 31, 2016

@Trott
Copy link
Member

Trott commented Aug 31, 2016

LGTM

2 similar comments
@santigimeno
Copy link
Member

LGTM

@Fishrock123
Copy link
Contributor

LGTM

@danbev
Copy link
Contributor Author

danbev commented Aug 31, 2016

Landed in 56414b5

@danbev danbev closed this Aug 31, 2016
danbev added a commit that referenced this pull request Aug 31, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@jbergstroem
Copy link
Member

🚂🚋 LGTM - welcome aboard the commit train ! 🚋🚋

@danbev
Copy link
Contributor Author

danbev commented Aug 31, 2016

@jbergstroem Thanks :)

@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
@danbev danbev deleted the adding-danbev-to-collaborators branch September 7, 2016 08:14
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants