Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for zlib.create*Raw() #8306

Closed
wants to merge 1 commit into from
Closed

test: add test for zlib.create*Raw() #8306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/parallel/test-zlib-create-raw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';

require('../common');
const assert = require('assert');
const zlib = require('zlib');

{
const inflateRaw = zlib.createInflateRaw();
assert(inflateRaw instanceof zlib.InflateRaw);
}

{
const deflateRaw = zlib.createDeflateRaw();
assert(deflateRaw instanceof zlib.DeflateRaw);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the scoping braces? No, not strictly necessary, but desirable IMO. Having every test in its own scope means (among other benefits) that you can freely add and remove variables in one test without worrying about side effects in any of the other tests. Right now, there's only two tests in this file but ideally more tests will be added over time.