Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: fix inspector hung while disconnecting #8021

Closed
wants to merge 1 commit into from
Closed

inspector: fix inspector hung while disconnecting #8021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ class V8NodeInspector : public blink::V8Inspector {
return;
terminated_ = false;
running_nested_loop_ = true;
agent_->DispatchMessages();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this thread-safe? DispatchMessages() reads and writes dispatching_messages_ without holding any locks.

do {
{
Mutex::ScopedLock scoped_lock(agent_->pause_lock_);
Expand Down