Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: favor === over == #8000

Closed
wants to merge 1 commit into from
Closed

benchmark: favor === over == #8000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/buffers/buffer-bytelength.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function main(conf) {
}

function buildString(str, times) {
if (times == 1) return str;
if (times === 1) return str;

return str + buildString(str, times - 1);
}
2 changes: 1 addition & 1 deletion benchmark/crypto/cipher-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function main(conf) {
var bob_secret = bob.computeSecret(alice.getPublicKey(), pubEnc, 'hex');

// alice_secret and bob_secret should be the same
assert(alice_secret == bob_secret);
assert(alice_secret === bob_secret);

var alice_cipher = crypto.createCipher(conf.cipher, alice_secret);
var bob_cipher = crypto.createDecipher(conf.cipher, bob_secret);
Expand Down
4 changes: 2 additions & 2 deletions benchmark/dgram/array-vs-concat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ function server() {
var onsend = type === 'concat' ? onsendConcat : onsendMulti;

function onsendConcat() {
if (sent++ % num == 0)
if (sent++ % num === 0)
for (var i = 0; i < num; i++) {
socket.send(Buffer.concat(chunk), PORT, '127.0.0.1', onsend);
}
}

function onsendMulti() {
if (sent++ % num == 0)
if (sent++ % num === 0)
for (var i = 0; i < num; i++) {
socket.send(chunk, PORT, '127.0.0.1', onsend);
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/dgram/multi-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function server() {
var socket = dgram.createSocket('udp4');

function onsend() {
if (sent++ % num == 0)
if (sent++ % num === 0)
for (var i = 0; i < num; i++)
socket.send(chunk, PORT, '127.0.0.1', onsend);
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/dgram/offset-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function server() {
var socket = dgram.createSocket('udp4');

function onsend() {
if (sent++ % num == 0)
if (sent++ % num === 0)
for (var i = 0; i < num; i++)
socket.send(chunk, 0, chunk.length, PORT, '127.0.0.1', onsend);
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/dgram/single-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function server() {
var socket = dgram.createSocket('udp4');

function onsend() {
if (sent++ % num == 0)
if (sent++ % num === 0)
for (var i = 0; i < num; i++)
socket.send(chunk, PORT, '127.0.0.1', onsend);
}
Expand Down
12 changes: 6 additions & 6 deletions benchmark/http/_http_simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var server = module.exports = http.createServer(function(req, res) {
var status = 200;

var n, i;
if (command == 'bytes') {
if (command === 'bytes') {
n = ~~arg;
if (n <= 0)
throw new Error('bytes called with n <= 0');
Expand All @@ -46,7 +46,7 @@ var server = module.exports = http.createServer(function(req, res) {
}
body = storedBytes[n];

} else if (command == 'buffer') {
} else if (command === 'buffer') {
n = ~~arg;
if (n <= 0)
throw new Error('buffer called with n <= 0');
Expand All @@ -58,7 +58,7 @@ var server = module.exports = http.createServer(function(req, res) {
}
body = storedBuffer[n];

} else if (command == 'unicode') {
} else if (command === 'unicode') {
n = ~~arg;
if (n <= 0)
throw new Error('unicode called with n <= 0');
Expand All @@ -67,14 +67,14 @@ var server = module.exports = http.createServer(function(req, res) {
}
body = storedUnicode[n];

} else if (command == 'quit') {
} else if (command === 'quit') {
res.connection.server.close();
body = 'quitting';

} else if (command == 'fixed') {
} else if (command === 'fixed') {
body = fixed;

} else if (command == 'echo') {
} else if (command === 'echo') {
res.writeHead(200, { 'Content-Type': 'text/plain',
'Transfer-Encoding': 'chunked' });
req.pipe(res);
Expand Down