test: fix hard coded deprecate message count #7927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending CI: https://ci.nodejs.org/job/node-test-pull-request/3472/ |
|
LGTM |
4 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
|
LGTM |
|
I'd reword the commit message as "test: don't hard code deprecation count". LGTM either way though. |
princejwesley
force-pushed
the
crypto.test.deprecated
branch
from
dead8a7 to
b16d9e6
Compare
jasnell
pushed a commit
that referenced
this pull request
Aug 1, 2016
PR-URL: #7927 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in c52a973 |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
PR-URL: #7927 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, crypto
Description of change
This PR fixes hard coded deprecate message count