Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean up test-buffer-badhex #7773

Merged
merged 1 commit into from
Sep 29, 2016
Merged

test: clean up test-buffer-badhex #7773

merged 1 commit into from
Sep 29, 2016

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Jul 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This test was recently introduced in
151d316
and could be cleaned up a bit.

Refs: #7602

It is possible this is not worthwhile enough, but I feel it is stilly to have bufX all within a single closure.

R=@addaleax
CI: https://ci.nodejs.org/job/node-test-pull-request/3323/

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Jul 17, 2016
@addaleax
Copy link
Member

¯_(ツ)_/¯

LGTM if CI is green

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jul 17, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jul 18, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 4, 2016

ping @Fishrock123

@imyller
Copy link
Member

imyller commented Sep 15, 2016

LGTM if still relevant

jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller
Copy link
Member

imyller commented Sep 20, 2016

New CI: https://ci.nodejs.org/job/node-test-pull-request/4166/

@Fishrock123
test: clean up test-buffer-badhex
e758bd5 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: nodejs#7602
PR-URL: nodejs#7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 merged commit e758bd5 into nodejs:master Sep 29, 2016
@Fishrock123 Fishrock123 deleted the cleanup-buffer-badhex-test branch September 29, 2016 14:05
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@Fishrock123 @jasnell
test: clean up test-buffer-badhex
acd8cac 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: #7602
PR-URL: #7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@Fishrock123
test: clean up test-buffer-badhex
2aaa755 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: #7602
PR-URL: #7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 added a commit that referenced this pull request Oct 11, 2016
@Fishrock123
test: clean up test-buffer-badhex
6dbda6a 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: #7602
PR-URL: #7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Fishrock123 @rvagg
test: clean up test-buffer-badhex
cc05991 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: #7602
PR-URL: #7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Fishrock123 @MylesBorins
test: clean up test-buffer-badhex
741373c 
This test was recently (at the time of writing) introduced in
151d316
and could be cleaned up a bit.

Refs: #7602
PR-URL: #7773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Fishrock123 @addaleax @cjihrig @JungMinu @jasnell @imyller @mscdex @MylesBorins