Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: provide example activities #7744

Closed
wants to merge 5 commits into from
Closed

meta: provide example activities #7744

wants to merge 5 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 15, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

meta

Description of change

Provide example activities to better distinguish Collaborator activities
from CTC member activities.

@nodejs/ctc

@Trott Trott added the meta Issues and PRs related to the general management of the project. label Jul 15, 2016
@misterdjules
Copy link

This definitely looks like an improvement. I think it would be even better if the changes in github.com//pull/7720 referred to the "Typical activities of a CTC member" paragraph added in this PR. Thank you for doing this!


* contributing code and documentation changes to improve the project
* merging pull requests
* commenting on issues and pull requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would reviewing be better instead of commenting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, although reviewing doesn't necessarily entail leaving an artifact of the review, whereas commenting does. I'd be fine with either word.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing and commenting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye @jasnell OK, changed it from commenting to reviewing and commenting

@Fishrock123
Copy link
Contributor

Hmmm, I'm a bit skeptical of this.

I have asserted quite in the past there is bare-minimal requirements for CTC and collaborators, particularly those who are not paid to work on Node.

People doing this for free should not feel obligated to give time when it isn't feasible.

So for collaborators, I've always said something along the lines of "only do what you can, this shouldn't be burdensome". For CTC members: "You're only required to attend meetings, it'd be cool if you'd do other stuff, but don't feel more pressured to".

@Trott
Copy link
Member Author

Trott commented Jul 15, 2016

@Fishrock123 None of these are listed as requirements, just typical activities. This is an attempt to answer the questions:

  • What is a Collaborator? What does a Collaborator do?
  • What does a CTC member do that a Collaborator doesn't?

@rvagg
Copy link
Member

rvagg commented Jul 16, 2016

@Trott how about adding "(these are not requirements for membership of the Collaborators group)" to the lead-in to the first list would help with @Fishrock123's concerns?

In the second list, how about something like "facilitate the smooth day-to-day running of the Node.js project", to reinforce that the CTC is supposed to be the oil, or grease, that keeps the machine going.

@Trott
Copy link
Member Author

Trott commented Jul 19, 2016

@Fishrock123 @rvagg I've added this paragraph to hopefully allay the concerns raised:

While the above are typical things done by Collaborators, there are no required
activities to retain Collaborator status. There is currently no process by which
inactive Collaborators are removed from the project.

@rvagg I also added your suggestion (slightly modified) for the CTC list. My only hesitation is that it is not specific in the least and the reason to introduce these lists was to give concrete examples of CTC activities vs. Collaborator activities.

@misterdjules Yes, I agree, and I will update that PR to refer to these items if this PR lands first (which I expect it will).

@Fishrock123
Copy link
Contributor

seems good to me

@bnoordhuis
Copy link
Member

Lukewarm LGTM. I suppose you might as well land it now that you've written it but I don't think it's hugely valuable.

The distinguishing characteristic of a CTC member versus a regular collaborator is that the former has decision power and the moral obligations that come with that. That's really all there is to it, IMO: contentious issues are decided by the CTC.

@Trott
Copy link
Member Author

Trott commented Jul 20, 2016

I guess I'd like to get the @nodejs/ctc temperature on this one. Like, choose one:

  • LGTM! Ship it!
  • -1. I don't like this.
  • Eh, whatever, I don't really care either way to be honest. Stop bugging me with notifications, please.

@misterdjules
Copy link

LGTM.

@Trott
Copy link
Member Author

Trott commented Jul 22, 2016

Trying to wrap this up one way or another, so I'm going to go ahead and land this sometime after another 24 hours unless someone on @nodejs/ctc indicates that they would prefer that it not land.

@Trott
Copy link
Member Author

Trott commented Jul 23, 2016

I'm labeling this ctc-agenda so that we can hopefully make a very quick decision as to whether or not to land it. I'm fine with landing it, and I'm fine with closing it without landing. I just don't want to leave it hanging open forever.

Normally, I'd take an LGTM or two as sufficient grounds for landing something absent an objection from anyone. But I'm inclined to be a lot more cautious with documenting CTC rules and related governance material.

@misterdjules
Copy link

@Trott I haven't seen any objection after the latest updates, and the CTC meeting's agenda seems really packed this week. Is it possible for other @nodejs/ctc members to weigh in today and only keep this on the CTC meeting's agenda if there are actually objections?

* merging pull requests
* reviewing and commenting on issues and pull requests
* participation in working groups
* helping users and novice contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see these reordered a bit by priority, with merging pull requests being the last in the list.. perhaps...

  • Helping users and novice contributors
  • Contributing code and documentation changes...
  • Reviewing and commenting on issues and pull requests
  • Participation in working groups
  • Merging pull requests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell I've re-ordered the list per your suggestion.

Trott added 5 commits July 28, 2016 14:23
Provide example activities to better distinguish Collaborator activities
from CTC member activities.
@Trott
Copy link
Member Author

Trott commented Jul 28, 2016

Per CTC meeting yesterday, I'm going to land this at this time. As with the quorum material, we can revise it or remove it if anyone objects subsequently.

Trott added a commit to Trott/io.js that referenced this pull request Jul 28, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: nodejs#7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
@Trott
Copy link
Member Author

Trott commented Jul 28, 2016

Landed in 99e2d43

@Trott Trott closed this Jul 28, 2016
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@Trott Trott deleted the shared branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants