Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up string_search #7686

Closed
wants to merge 1 commit into from
Closed

src: clean up string_search #7686

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jul 12, 2016 •
edited
Loading

This is a partial backport of #7174. A couple of the changes were not valid for v4.x.

@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. v4.x labels Jul 12, 2016
@mscdex mscdex force-pushed the v4.x-string-search-lint branch from 2406c7d to fd3c95e Compare July 12, 2016 16:36
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jul 12, 2016
@mscdex mscdex force-pushed the v4.x-string-search-lint branch from fd3c95e to 839ad6c Compare July 12, 2016 16:40
@addaleax
Copy link
Member

LGTM

@MylesBorins
Copy link
Contributor

@mscdex this is going to need a rebase, thanks for the patience

@mscdex
src: clean up string_search
13abb8d 
This commit removes some unnecessary signed checks on unsigned
variables.

PR-URL: nodejs#7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex force-pushed the v4.x-string-search-lint branch from 839ad6c to 13abb8d Compare July 12, 2016 17:45
@mscdex
Copy link
Contributor Author

mscdex commented Jul 12, 2016

Yeah I don't know how that happened. It's fixed now anyway.

@MylesBorins
Copy link
Contributor

landed in 6519e02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mscdex @addaleax @MylesBorins