Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add lance to collaborators. #7407

Closed
wants to merge 1 commit into from
Closed

doc: add lance to collaborators. #7407

wants to merge 1 commit into from

Conversation

lance
Copy link
Member

@lance lance commented Jun 24, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add @lance to collaborator list on README.md

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 24, 2016
@Trott
Copy link
Member

Trott commented Jun 24, 2016

Nit: no period at the end of the first commit line

@addaleax
Copy link
Member

LGTM with @Trott’s nit, welcome!

@Trott
Copy link
Member

Trott commented Jun 24, 2016

LGTM with a nit

@cjihrig
Copy link
Contributor

cjihrig commented Jun 24, 2016

LGTM

lance added a commit that referenced this pull request Jun 24, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
@lance
Copy link
Member Author

lance commented Jun 24, 2016

Landed in 0b9e135

@lance lance closed this Jun 24, 2016
@lance lance deleted the add-lance-to-readme branch June 24, 2016 17:31
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants