src: remove unused internals from node.cc #7117
Conversation
Remove a couple of internal methods that are neither exported in the public headers nor used internally anywhere.
addaleax
added
c++
|
+1 for removing stuff that's no longer needed. LGTM if CI is green and @bnoordhuis is happy with it. |
|
Nice. LGTM. CI came back green. |
|
LGTM |
Remove a couple of internal methods that are neither exported in the public headers nor used internally anywhere. PR-URL: nodejs#7117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in de4161d |
|
@addaleax Is this safe to land on v6? |
|
@evanlucas It should be, but you can feel completely free to leave it out. The point here is to clean up the code base we’re working with, whether it ends up in a v6 release or not is very likely irrelevant. |
|
Is there any way this would be an ABI breakage? Could some native addons be using the removed MakeCallback? |
|
Only if they declared the functions themselves in their own code, or if they included the internal headers with |
|
Ok, thanks for the clarification @addaleax! |
Checklist
Affected core subsystem(s)
src
Description of change
Remove a couple of internal wrapper methods that are neither exported in the public headers nor used internally anywhere and imho have no real value being kept around.
CI: https://ci.nodejs.org/job/node-test-commit/3632/