Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update rpmbuild .spec file #71

Merged
merged 2 commits into from
Dec 5, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions tools/rpm/node.spec → tools/rpm/iojs.spec
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
# This is updated by rpmbuild.sh.
%define _version 0.10.12

Name: node
Name: iojs
Version: %{_version}
Release: 1
Summary: Node.js is a platform for building fast, scalable network applications.
Summary: io.js is a platform for building fast, scalable network applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "io.js" lowercased even if it starts a sentence?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we should note it somewhere like npm guys did. Maybe in readme.

Group: Development/Languages
License: MIT
URL: http://nodejs.org/
Source0: http://nodejs.org/dist/v%{_version}/node-v%{_version}.tar.gz
URL: http://iojs.org/
Source0: http://iojs.org/dist/v%{_version}/iojs-v%{_version}.tar.gz
BuildRequires: gcc
BuildRequires: gcc-c++
BuildRequires: glibc-devel
Expand All @@ -37,10 +37,10 @@ Conflicts: nodejs


%description
Node.js is a platform built on Chrome's JavaScript runtime for easily
io.js is a platform built on Chrome's JavaScript runtime for easily
building fast, scalable network applications.

Node.js uses an event-driven, non-blocking I/O model that makes it
io.js uses an event-driven, non-blocking I/O model that makes it
lightweight and efficient, perfect for data-intensive real-time
applications that run across distributed devices.

Expand Down Expand Up @@ -71,10 +71,10 @@ make %{?_smp_mflags}


# Use mildly hard-coded paths in the install and files targets for now.
# _libdir is /usr/lib64 on some systems but the node.js installer always
# installs to /usr/lib. I have commits sitting in a branch that add --libdir
# and --mandir configure switches to the node.js configure script but it's
# debatable if it's worth the extra complexity.
# _libdir is /usr/lib64 on some systems but the installer always installs
# to /usr/lib. I have commits sitting in a branch that add --libdir and
# --mandir configure switches to the configure script but it's debatable
# if it's worth the extra complexity.
%install
export DONT_STRIP=1 # Don't strip debug symbols for now.
make install DESTDIR=%{buildroot}
Expand All @@ -100,5 +100,8 @@ done


%changelog
* Thu Dec 4 2014 Ben Noordhuis <info@bnoordhuis.nl>
- Rename to iojs.

* Fri Jul 5 2013 Ben Noordhuis <info@bnoordhuis.nl>
- Initial release.
8 changes: 4 additions & 4 deletions tools/rpm/rpmbuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fi
set -x

sed -re "s/%define _version .+/%define _version ${VERSION}/" \
"$TOOLSDIR/node.spec" > $RPMBUILD_PATH/SPECS/node.spec
tar --exclude-vcs --transform="s|^|node-${VERSION}/|" \
-czf $RPMBUILD_PATH/SOURCES/node-v${VERSION}.tar.gz .
rpmbuild $* -ba $RPMBUILD_PATH/SPECS/node.spec
"$TOOLSDIR/iojs.spec" > $RPMBUILD_PATH/SPECS/iojs.spec
tar --exclude-vcs --transform="s|^|iojs-${VERSION}/|" \
-czf $RPMBUILD_PATH/SOURCES/iojs-v${VERSION}.tar.gz .
rpmbuild $* -ba $RPMBUILD_PATH/SPECS/iojs.spec