Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport for v4.x: win,build: add creation of zip and 7z package #7075

Conversation

joaocgreis
Copy link
Member

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

win, build

Description of change

@nodejs/lts

This is a backport of #5995. The commit applies almost cleanly (some context change), but I also want to start a test build and have a proper place for discussion.

Added the don't-land label to the original PR, please change if not appropriate.

I believe this should go into v4, but not sure about v0.12 and v0.10.

@joaocgreis joaocgreis added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. lts-watch-v4.x lts Issues and PRs related to Long Term Support releases. labels May 31, 2016
@joaocgreis
Copy link
Member Author

@rvagg
Copy link
Member

rvagg commented May 31, 2016

Let's leave 0.10 and 0.12 alone, we've tried to keep the dist directories fairly static and there's already some .pdb stuff in there anyway.

I'm fine with this for v4.x but would much rather wait till we've had a few releases of v6 to verify that we've got it sorted out first.

This looks like a straightforward backport without anything different from the original, is that correct @joaocgreis? If so, lgtm.

@joaocgreis
Copy link
Member Author

This looks like a straightforward backport without anything different from the original

@rvagg that is correct.

I'm ok with waiting. This is ready to go in, but there's no reason to rush. I'll rebase and ping when there are a couple of releases of v6 out with this.

@MylesBorins
Copy link
Contributor

thanks @joaocgreis

@MylesBorins MylesBorins force-pushed the v4.x-staging branch 3 times, most recently from ed3d372 to f14d9cf Compare June 28, 2016 22:49
@MylesBorins
Copy link
Contributor

@joaocgreis looks like this needs a rebase

Add a step in vcbuild.bat to create a minimal package including node
and npm that can be used as an alternative to the MSI.

Compress the node.pdb file as zip and 7z.

All files are uploaded as part of build-release.

Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
PR-URL: nodejs#5995
Fixes: nodejs/build#299
Fixes: nodejs#5696
@joaocgreis joaocgreis force-pushed the Bartosz-MakeWindowsZipPackage-4.x branch from 00b2963 to c21b63c Compare July 5, 2016 20:03
@joaocgreis
Copy link
Member Author

Rebased. Should we start another test build?

@MylesBorins
Copy link
Contributor

@joaocgreis
Copy link
Member Author

CI green, here is another test build: https://nodejs.org/download/test/v4.4.8-test20160707c21b63cbf0770fcf0b9e4a4fbe160d6eb87bfd3e/

@rvagg @thealphanerd LGTY? (and should I land this myself?)

@rvagg
Copy link
Member

rvagg commented Jul 7, 2016

lgtm pending an RC or test build

@MylesBorins
Copy link
Contributor

MylesBorins commented Jul 8, 2016

landed in b69bcaf

This will be included in the v4.5.0 rc's that will be put together soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. lts Issues and PRs related to Long Term Support releases. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants