Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function #6977

Closed
wants to merge 1 commit into from
Closed

Conversation

zwhitchcox
Copy link

@zwhitchcox zwhitchcox commented May 25, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Replaced deprecated util._extend with Object.assign per documentation

Replaced deprecated util._extend with Object.assign per [documentation](https://nodejs.org/api/util.html#util_util_extend_obj)
@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label May 25, 2016
@mscdex
Copy link
Contributor

mscdex commented May 25, 2016

I don't think the deprecation was really intended for node core as much as it was for userland. See the original discussion here. One of the reasons is that Object.assign() is/was slower. The changes would need to be benchmarked first before this PR would be landed, to see if it is still slower and by how much.

@addaleax
Copy link
Member

quick & dirty benchmarking shows that Object.assign({}, process.env) is still about 50 % slower for me than util._extend({}, process.env), so yes, this PR would probably not improve things performance-wise.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 1, 2016

I'm going to close this for now. We can revisit when performance of Object.assign() improves, or if it is used in a way that makes it a better option than util._extend().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants