Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run known_issues tests in CI #6559

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented May 4, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Add known_issues tests to make test and make test-ci targets and
their equivalents on Windows.

This should not land until #6555 lands first. (#6555 landed, woot.)

/cc @cjihrig @Fishrock123 @nodejs/testing ... and whoever the Python folks are who can tell me if I'm Doing It Wrong in testcfg.py... @thefourtheye? @bnoordhuis? @jbergstroem? Someone else?

Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.
@Trott Trott added test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress. labels May 4, 2016
@Trott
Copy link
Member Author

Trott commented May 4, 2016

Added the in progress flag so that @jasnell et al. don't bother having to read the description to find out that they shouldn't land this until #6555 lands first.

@jasnell
Copy link
Member

jasnell commented May 4, 2016

Appreciate it! Use of the labels really helps save time.

@orangemocha
Copy link
Contributor

cc @joaocgreis

@Trott Trott removed the wip Issues and PRs that are still a work in progress. label May 6, 2016
@Trott
Copy link
Member Author

Trott commented May 6, 2016

#6555 landed, which means this can land, so I'm removing the in progress label.

@Trott
Copy link
Member Author

Trott commented May 6, 2016

@Trott
Copy link
Member Author

Trott commented May 6, 2016

Single test failure in CI looks unrelated. Opened an "investigate flaky test" issue for it. Re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2521/

@Trott
Copy link
Member Author

Trott commented May 6, 2016

CI is green.

/bump @nodejs/collaborators

@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

LGTM, but I'm not comfortable being the only sign off on Python code :-)

@addaleax
Copy link
Member

addaleax commented May 6, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request May 6, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.

PR-URL: nodejs#6559
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented May 6, 2016

Landed in 5d0b1f4

@Trott Trott closed this May 6, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.

PR-URL: #6559
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
Copy link
Contributor

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Jun 2, 2016

@thealphanerd Yes.

@MylesBorins
Copy link
Contributor

@Trott does not land cleanly.. feel free to backport

@Trott
Copy link
Member Author

Trott commented Jun 3, 2016

It's not essential. I'm OK with leaving it out.

aqrln pushed a commit that referenced this pull request Apr 9, 2017
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
* Since nodejs#6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: nodejs#12262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
* Since nodejs/node#6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: nodejs/node#12262
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott deleted the cnown branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants