Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: discourage use of util.inherits; point to es6 extends #6514

Closed
wants to merge 6 commits into from
Closed

doc: discourage use of util.inherits; point to es6 extends #6514

wants to merge 6 commits into from

Commits on May 2, 2016

  1. doc: discourage use of util.inherits; point to es6 extends 

    util.inherits breaks the prototype chain. A fix does not seem
useful, since ES6 extends provides language level support for the
same functionality.

This commit starts fasing out mentions of the method.

Fixes: #4179
    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 2, 2016
    Configuration menu
    Copy the full SHA
    e5f6fef View commit details
    Browse the repository at this point in the history

  2. doc: util.inherits removal, address review

    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 2, 2016
    Configuration menu
    Copy the full SHA
    28332bb View commit details
    Browse the repository at this point in the history

  3. doc: util.inherits removal, remove no-new-if-checks

    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 2, 2016
    Configuration menu
    Copy the full SHA
    e97064d View commit details
    Browse the repository at this point in the history

  4. doc: util.inherits removal, missed semicolon

    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 2, 2016
    Configuration menu
    Copy the full SHA
    339f823 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2016

  1. doc: util.inherits removal, note incompatiblity

    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 3, 2016
    Configuration menu
    Copy the full SHA
    c6d6a1d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. doc: util.inherits removal: link to github issue for incompat

    @eljefedelrodeodeljefe
    eljefedelrodeodeljefe committed May 6, 2016
    Configuration menu
    Copy the full SHA
    06441f4 View commit details
    Browse the repository at this point in the history