Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make use of globals explicit #6014

Closed
wants to merge 1 commit into from
Closed

test: make use of globals explicit #6014

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 2, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test vm

Description of change

Use global to be explicit that a global variable is intended.

Use `global` to be explicit that a global variable is intended.
@Trott Trott added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. lts-watch-v4.x labels Apr 2, 2016
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2016
Use `global` to be explicit that a global variable is intended.

PR-URL: nodejs#6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 5, 2016

Landed in d416a59

@Trott Trott closed this Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Use `global` to be explicit that a global variable is intended.

PR-URL: #6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Use `global` to be explicit that a global variable is intended.

PR-URL: #6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
@Trott Trott deleted the vim branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants