http: don't bother making a copy of the options #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to #592. The `options` object is never overwritten, so making a copy is not necessary. This solves issues such as https://github.com/petkaantonov/urlparser/issues where the options object is created from a constructor.
|
LGTM |
Qard
pushed a commit
that referenced
this pull request
Jan 24, 2015
Alternative to #592. The `options` object is never overwritten, so making a copy is not necessary. This solves issues such as https://github.com/petkaantonov/urlparser/issues where the options object is created from a constructor. PR-URL: #593 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
merged in 06cfff9 |
|
👍 |
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #592. The
optionsobject is never overwritten, so making a copy is not necessary.This solves issues such as https://github.com/petkaantonov/urlparser/issues where the options object is created from a constructor.