build: introduce ci targets for lint/benchmark #5921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI.
jbergstroem
added
build
| .PHONY: lint cpplint jslint bench clean docopen docclean doc dist distclean \ | ||
| check uninstall install install-includes install-bin all staticlib \ | ||
| dynamiclib test test-all test-addons build-addons website-upload pkg \ | ||
| blog blogclean tar binary release-only bench-http-simple bench-idle \ | ||
| bench-all bench bench-misc bench-array bench-buffer bench-net \ | ||
| bench-http bench-fs bench-tls cctest run-ci test-v8 test-v8-intl \ | ||
| test-v8-benchmarks test-v8-all v8 | ||
| test-v8-benchmarks test-v8-all v8 lint-ci |
There was a problem hiding this comment.
Can we remove lint at the beginning of this then?
There was a problem hiding this comment.
no, its still a target?
|
Do we need to also reserve a |
|
@mscdex said:
I was thinking no since we could just do what we need to in |
|
LGTM then |
|
As long as we have |
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 1, 2016
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. PR-URL: #5921 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 8dcb82d |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. PR-URL: #5921 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. PR-URL: #5921 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
build
Description of change
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. Refs #5638.
The gist of the problem is that we can't call makefile targets through CI that doesn't exist in all branches we test on. Meaning, the quicker we get it in, the easier it will be to expand on changes to linting, testing and benchmarking (making sure we call respective
-citargets from CI).vcbuild.batchanges are missing, but linting and benchmarking needs more improvements than just ci - and we don't invoke linting/benchmarking stuff from Windows just yet./cc @nodejs/build, @mscdex