Skip to content

fix: TextDecoder Big5 invalid sequence handling #59046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: TextDecoder Big5 invalid sequence handling #59046

wants to merge 1 commit into from
+58 −34

Conversation

68Lihua
Copy link

@68Lihua 68Lihua commented Jul 13, 2025

Fixes #40091: TextDecoder does not error incorrectly for legacy byte sequences

  • Added test case for invalid Big5 sequence [0x83, 0x5C]
  • Configured ICU decoder to use replacement character (U+FFFD) for invalid bytes
  • Test passes after the fix

@nodejs-github-bot nodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. labels Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextDecoder does not error incorrectly for legacy byte sequences
2 participants
@68Lihua @nodejs-github-bot