-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test-cluster-shared-leak #5802
test: fix flaky test-cluster-shared-leak #5802
Conversation
Test was flaky on centos7-64 due to an uncaught ECONNRESET on the worker code. This catches the error so the process will exit with code 0. Fixes: nodejs#5604
P.P.S: not the first time centos has this kind of behaviour on the CI, there's several tests that had "flaky" behaviour because of prematurely closed connections in that platform. That probably warrants further investigation. |
LGTM |
@nodejs/testing |
Confirmed that this still catches the error it's supposed to catch in Node v4.2.1. |
LGTM. |
LGTM |
I assume this is relevant for v4 also, please remove the lts-watch label if not! thanks! |
Landed in 74a703d |
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test
(UNIX) orvcbuild test nosign
(Windows) pass withthis change (including linting)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
test
Description of change
Please provide a description of the change here.
Test was flaky on centos7-64 due to an uncaught ECONNRESET on the worker code. This catches the error so the process will exit with code 0.
Fixes: #5604
PS: I did consider retrying but
ECONNRESET
was already being disregarded on the cluster-master side of things, and the test itself is concerned with a particular assertion incluster
, but I'd still like some feedback on this.You can reproduce the error by adding a timeout like this: