Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add qard to collaborators #578

Closed
wants to merge 1 commit into from
Closed

doc: add qard to collaborators #578

wants to merge 1 commit into from

Conversation

Qard
Copy link
Member

@Qard Qard commented Jan 23, 2015

Adding myself to collaborators list.

@Fishrock123
Copy link
Contributor

LGTM. Might want to check out comments on f3fed51 though. :)

@rvagg
Copy link
Member

rvagg commented Jan 23, 2015

Woo! LGTM

@Fishrock123 you need to get yourself on too.

@Fishrock123
Copy link
Contributor

eventually™

@Qard
Copy link
Member Author

Qard commented Jan 23, 2015

@Fishrock123 Does that look good?

@Fishrock123
Copy link
Contributor

Formatting's good, though I think @rvagg uses <rod@vagg.org> since that's what's in the readme.

@Qard
Copy link
Member Author

Qard commented Jan 23, 2015

Indeed. I grabbed from his user page, which seems to be different. I used the one from the readme now. :)

@chrisdickinson
Copy link
Contributor

LGTM!

PR-URL: nodejs#578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Qard added a commit that referenced this pull request Jan 23, 2015
PR-URL: #578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
@Qard Qard closed this Jan 23, 2015
@jesec jesec mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants