-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: do not expose simdjson.h in node_config_file.h #57173
Merged
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57173 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 629 629
Lines 184373 184373
Branches 36027 36022 -5
=======================================
Hits 166609 166609
- Misses 10907 10915 +8
+ Partials 6857 6849 -8 |
anonrig
approved these changes
Feb 22, 2025
lpinca
approved these changes
Feb 22, 2025
jasnell
approved these changes
Feb 23, 2025
StefanStojanovic
approved these changes
Feb 24, 2025
richardlau
approved these changes
Feb 24, 2025
Landed in 8a9c3c2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v23.x
PRs that should not land on the v23.x-staging branch and should not be released in v23.x.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed, and on Windows files including the header needs some other configs otherwise errors like this may happen: