doc: add module namespace object links
#57093
Closed
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
jasnell
approved these changes
Feb 16, 2025
UlisesGascon
approved these changes
Feb 16, 2025
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
cjihrig
approved these changes
Feb 16, 2025
lpinca
approved these changes
Feb 17, 2025
dario-piotrowicz
force-pushed
the
dario/docs/connonjs-page/add-module-namespace-object-link
branch
from
1f4ecff to
4cbd5a8
Compare
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57093 ✔ Done loading data for nodejs/node/pull/57093 ----------------------------------- PR info ------------------------------------ Title doc: add `module namespace object` links (#57093) Author Dario Piotrowicz <dario.piotrowicz@gmail.com> (@dario-piotrowicz) Branch dario-piotrowicz:dario/docs/connonjs-page/add-module-namespace-object-link -> nodejs:main Labels doc, module, fast-track Commits 1 - doc: add `module namespace object` links Committers 1 - Dario Piotrowicz <dario@cloudflare.com> PR-URL: https://github.com/nodejs/node/pull/57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: add `module namespace object` links ℹ This PR was created on Sun, 16 Feb 2025 12:02:18 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57093#pullrequestreview-2619654503 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/57093#pullrequestreview-2619660158 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57093#pullrequestreview-2619725467 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57093#pullrequestreview-2621841297 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13396234456 |
jasnell
pushed a commit
that referenced
this pull request
Feb 18, 2025
PR-URL: #57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 0192a7d |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 24, 2025
PR-URL: #57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
PR-URL: #57093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.