Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flakiness on macOS test #56971

Closed
wants to merge 2 commits into from
Closed

test: remove flakiness on macOS test #56971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8e6b9
test: remove flakiness on macOS test
anonrig Feb 9, 2025
a712b4f
test: reduce flakiness on test-net-write-fully-async-buffer
anonrig Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-fully-async-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const server = net.createServer(common.mustCall(function(conn) {
}

while (conn.write(Buffer.from(data)));
globalThis.gc({ type: 'minor' });
globalThis.gc({ type: 'major' });
// The buffer allocated above should still be alive.
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-fully-async-hex-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const server = net.createServer(common.mustCall(function(conn) {
}

while (conn.write(data, 'hex'));
globalThis.gc({ type: 'minor' });
globalThis.gc({ type: 'major' });
// The buffer allocated inside the .write() call should still be alive.
}

Expand Down
Loading