Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: link with Security.framework in GN build #56895

Closed
wants to merge 1 commit into from
Closed

build: link with Security.framework in GN build #56895

wants to merge 1 commit into from
+4 −1

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 3, 2025

Update the GN build file to match the changes in #56599.

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2025
@lpinca
Copy link
Member

lpinca commented Feb 3, 2025 •
edited
Loading

I think build: or build,crypto: would be a better subsystem in commit title.

@zcbenz zcbenz changed the title crypto: link with Security.framework in GN build build,crypto: link with Security.framework in GN build Feb 4, 2025
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64973/

zcbenz added a commit that referenced this pull request Feb 7, 2025
@zcbenz
build: link with Security.framework in GN build
19bfc83 
PR-URL: #56895
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@zcbenz zcbenz changed the title build,crypto: link with Security.framework in GN build build: link with Security.framework in GN build Feb 7, 2025
@zcbenz
Copy link
Contributor Author

zcbenz commented Feb 7, 2025

Landed in 19bfc83

@zcbenz zcbenz closed this Feb 7, 2025
@zcbenz zcbenz deleted the gn-crypto-mac branch February 7, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zcbenz @lpinca @nodejs-github-bot @jasnell @joyeecheung