Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] doc: add note for features using InternalWorker with permission model #56721

Closed
wants to merge 1 commit into from
Closed

[v20.x backport] doc: add note for features using InternalWorker with permission model #56721

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 23, 2025 •
edited
Loading

Backport of: #56706

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jan 23, 2025
@aduh95 aduh95 mentioned this pull request Jan 23, 2025
Merged
@marco-ippolito marco-ippolito requested a review from a team as a code owner January 23, 2025 12:58
@aduh95
doc: add note for features using InternalWorker with permission model
c30b0c0 
PR-URL: nodejs#56706
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 force-pushed the internal-worker--permission branch from 2ac8dac to c30b0c0 Compare January 23, 2025 13:25
marco-ippolito pushed a commit that referenced this pull request Jan 23, 2025
@aduh95 @marco-ippolito
doc: add note for features using InternalWorker with permission model
fcd744e 
PR-URL: #56706
Backport-PR-URL: #56721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito
Copy link
Member

Landed in fcd744e

@aduh95 aduh95 deleted the internal-worker--permission branch January 23, 2025 15:33
marco-ippolito pushed a commit that referenced this pull request Jan 23, 2025
@aduh95 @marco-ippolito
doc: add note for features using InternalWorker with permission model
d67900e 
PR-URL: #56706
Backport-PR-URL: #56721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jan 24, 2025
@aduh95 @marco-ippolito
doc: add note for features using InternalWorker with permission model
f07be5e 
PR-URL: #56706
Backport-PR-URL: #56721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @marco-ippolito @richardlau