Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm in LTS to 2.14.21 for Node.js 0.10 Maintenance #5593

Closed
wants to merge 1 commit into from

Conversation

othiym23
Copy link
Contributor

@othiym23 othiym23 commented Mar 8, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

  • deps

Description of change

Upgrades the v0.10 maintenance branch to use npm@lts / npm@2.

Testing this is going to require something like citgm, because 0.10 has the old, broken test-npm stanza in the Makefile. I can tell you that this build has passed running with Node 0.10 in Travis.

I tried to be conservative about what tags I applied, and apologize in advance if I misinterpreted the meanings of the ones that I set. This might also need lts-agenda, since I understand this will be discussed at this week's LTS meeting.

r: @thealphanerd
r: @Fishrock123

@othiym23 othiym23 added npm Issues and PRs related to the npm client dependency or the npm registry. land-on-v0.10 lts Issues and PRs related to Long Term Support releases. labels Mar 8, 2016
@rvagg
Copy link
Member

rvagg commented Mar 8, 2016

Nice, thanks @othiym23! @thealphanerd what are the chances of getting citgm going here?

@othiym23
Copy link
Contributor Author

othiym23 commented Mar 8, 2016

Also, npm@2.14.21 includes the updated LICENSE which includes the removal of the potentially confusing web site and registry Terms of Use. v0.10 doesn't have the license updating tool, so is there a best practice for updating the top-level LICENSE to reflect the changed npm license?

@othiym23 othiym23 changed the title deps: upgrade npm in LTS to 2.14.21 for Node.js 0.01 Maintenance deps: upgrade npm in LTS to 2.14.21 for Node.js 0.10 Maintenance Mar 8, 2016
@MylesBorins
Copy link
Contributor

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/106/

I have no idea if this is going to work on v0.10.x

Fingers crossed 😄

edit: gotta change some flags for v0.10 Will get it up soon

@MylesBorins
Copy link
Contributor

Here's another attempt at citgm: https://ci.nodejs.org/job/thealphanerd-smoker-no-intl/5/

This should work. Found some sever major changes between 0.10 and above that were broken in citgm... this should fix it

@MylesBorins
Copy link
Contributor

One more time: https://ci.nodejs.org/job/thealphanerd-smoker-no-intl/6/

edit: the moment failures we are seeing in moment are being tracked upstream moment/moment#3016

@mattjohnsonpint
Copy link

WRT the moment.js error, it's DST related, and should go away on its own by this Monday. We have a fix pending in a PR, but see no need to push a hotfix release for such a minor issue at this time.

@ChALkeR
Copy link
Member

ChALkeR commented Apr 11, 2016

Could this be closed now?

@MylesBorins
Copy link
Contributor

we have a newer version of npm in v0.10 now. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lts Issues and PRs related to Long Term Support releases. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants