Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-eventsource.js to use new test runner #55747

Closed

Conversation

tlhunter
Copy link
Contributor

@tlhunter tlhunter commented Nov 6, 2024

  • updating a test to use the new test runner
  • NodeConfEU says hi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2024
@avivkeller
Copy link
Member

IMHO this isn't needed because there's only a single test

@bengl bengl added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2024
@bengl
Copy link
Member

bengl commented Nov 6, 2024

The descriptive text adds extra context in case this test fails, so it seems useful even for single tests like this.

@bengl bengl added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (1aa7135) to head (63cfef7).
Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55747      +/-   ##
==========================================
- Coverage   88.40%   88.40%   -0.01%     
==========================================
  Files         654      654              
  Lines      187747   187747              
  Branches    36127    36126       -1     
==========================================
- Hits       165972   165970       -2     
- Misses      15009    15013       +4     
+ Partials     6766     6764       -2     

see 23 files with indirect coverage changes

---- 🚨 Try these New Features:

@lpinca
Copy link
Member

lpinca commented Nov 6, 2024

IMHO this isn't needed because there's only a single test

I agree. It's totally useless, slows down test execution, etc. I'm not sure why this "refactor to use node:test" was chosen as a code and learn exercise when there is no official TSC stance against it and there are contributors (me in primis) who are against it. I don't block these PRs out of respect for the authors who probably don't know about it.

@nodejs-github-bot
Copy link
Collaborator

@tlhunter tlhunter closed this Nov 24, 2024
@tlhunter tlhunter deleted the tlhunter/test-eventsource-summit branch November 24, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants