Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: provide workaround for container-overflow (issue 55584) #55591

Merged
merged 2 commits into from
Nov 6, 2024
Merged

src: provide workaround for container-overflow (issue 55584) #55591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1537e3f
src: provide workaround for container-overflow (issue 55584)
lemire Oct 29, 2024
f80d465
lint
lemire Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/node_modules.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,23 @@ const BindingData::PackageConfig* BindingData::GetPackageJSON(
if (ReadFileSync(&package_config.raw_json, path.data()) < 0) {
return nullptr;
}
// In some systems, std::string is annotated to generate an
// AddressSanitizer: container-overflow error when reading beyond the end of
// the string even when we are still within the capacity of the string.
// https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow
// https://github.com/nodejs/node/issues/55584
// The next lines are a workaround to avoid this false positive.
size_t json_length = package_config.raw_json.size();
package_config.raw_json.append(simdjson::SIMDJSON_PADDING, ' ');
simdjson::padded_string_view json_view(package_config.raw_json.data(),
json_length,
package_config.raw_json.size());
// End of workaround

simdjson::ondemand::document document;
simdjson::ondemand::object main_object;
simdjson::error_code error =
binding_data->json_parser.iterate(package_config.raw_json).get(document);
binding_data->json_parser.iterate(json_view).get(document);

const auto throw_invalid_package_config = [error_context, path, realm]() {
if (error_context == nullptr) {
Expand Down
Loading