Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: remove dirent.path #55548

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fs: remove dirent.path #55548

merged 1 commit into from
Nov 14, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 26, 2024

Marking as blocked PRs that are blocked by other issues or PRs. because it should land after #55547

Fixes: #55538

@aduh95 aduh95 added semver-major PRs that contain breaking changes and should be released in the next major version. blocked PRs that are blocked by other issues or PRs. labels Oct 26, 2024
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 26, 2024
mcollina
mcollina approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avivkeller avivkeller added the deprecations Issues and PRs related to deprecations. label Oct 26, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (b52a49b) to head (d9540b5).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55548   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         654      654           
  Lines      187824   187811   -13     
  Branches    36134    36134           
=======================================
- Hits       166060   166059    -1     
+ Misses      15005    14992   -13     
- Partials     6759     6760    +1
Files with missing lines Coverage Δ
lib/internal/fs/utils.js 99.69% <ø> (-0.01%) ⬇️

... and 41 files with indirect coverage changes

@aduh95 aduh95 mentioned this pull request Oct 26, 2024
Merged
LiviaMedeiros
LiviaMedeiros approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with fixes to tests that use this property.

doc/api/deprecations.md Outdated Show resolved Hide resolved
targos
targos reviewed Oct 28, 2024
View reviewed changes
doc/api/deprecations.md Outdated Show resolved Hide resolved
@LiviaMedeiros LiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Oct 29, 2024
@aduh95 aduh95 force-pushed the remove-dirent.path branch from 842336a to f819bc1 Compare November 6, 2024 23:22
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63465/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63466/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63467/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63469/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63482/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 14, 2024
aduh95 added a commit to aduh95/node that referenced this pull request Nov 14, 2024
@aduh95
fs: remove dirent.path
d224cf4 
PR-URL: nodejs#55548
Fixes: nodejs#55538
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95 aduh95 force-pushed the remove-dirent.path branch from 1704be9 to d224cf4 Compare November 14, 2024 23:17
@aduh95
fs: remove dirent.path
d9540b5 
PR-URL: nodejs#55548
Fixes: nodejs#55538
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95 aduh95 force-pushed the remove-dirent.path branch from d224cf4 to d9540b5 Compare November 14, 2024 23:18
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 14, 2024

Landed in d9540b5

@aduh95 aduh95 merged commit d9540b5 into nodejs:main Nov 14, 2024
20 checks passed
@aduh95 aduh95 deleted the remove-dirent.path branch November 14, 2024 23:19
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
fs: remove dirent.path
c69cadf 
PR-URL: nodejs#55548
Fixes: nodejs#55538
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@aduh95 @Ceres6
fs: remove dirent.path
93dce8a 
PR-URL: nodejs#55548
Fixes: nodejs#55538
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file.path is only a getter
8 participants
@aduh95 @nodejs-github-bot @mcollina @anonrig @targos @Ethan-Arrowood @LiviaMedeiros @avivkeller