-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: report error on missing sourcemap source #55037
base: main
Are you sure you want to change the base?
test_runner: report error on missing sourcemap source #55037
Conversation
Review requested:
|
'# index.ts | 100.00 | 100.00 | 100.00 | ', | ||
'# ------------------------------------------------------------------', | ||
'# all files | 100.00 | 100.00 | 100.00 | ', | ||
'# ------------------------------------------------------------------', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review note
I moved source-map-line-lengths
into source-map/line-lengths
, hence this change.
Fixes nodejs#54756 Co-Authored-By: Colin Ihrig <cjihrig@gmail.com> Co-Authored-By: Jayden Seric <me@jaydenseric.com>
3723a8d
to
4badc52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55037 +/- ##
==========================================
- Coverage 88.23% 88.23% -0.01%
==========================================
Files 652 652
Lines 183855 183864 +9
Branches 35856 35855 -1
==========================================
+ Hits 162227 162230 +3
- Misses 14909 14914 +5
- Partials 6719 6720 +1
|
Fixes #54756
ERR_SOURCE_MAP_MISSING_SOURCE
is now thrown when a sourcemap contains a reference to a non-existent file.@jaydenseric provided the test fixture, and @cjihrig provided the initial patch.