Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: merge knownGlobals in common #54915

Closed
wants to merge 1 commit into from

Conversation

RedYetiDev
Copy link
Member

The knownGlobals array can be simplified, as shown in this PR

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 12, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (92ca0b7) to head (4799bf6).
Report is 148 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54915      +/-   ##
==========================================
- Coverage   88.06%   88.06%   -0.01%     
==========================================
  Files         651      651              
  Lines      183409   183409              
  Branches    35822    35829       +7     
==========================================
- Hits       161519   161512       -7     
- Misses      15148    15157       +9     
+ Partials     6742     6740       -2     

see 22 files with indirect coverage changes

@aduh95
Copy link
Contributor

aduh95 commented Sep 13, 2024

I still think #42056 would be a better approach

@RedYetiDev
Copy link
Member Author

Closing in favor

@RedYetiDev RedYetiDev closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants