Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, meta: fix broken link in onboarding.md #54886

Merged
merged 1 commit into from
Sep 12, 2024
Merged

doc, meta: fix broken link in onboarding.md #54886

merged 1 commit into from
Sep 12, 2024

Conversation

RedYetiDev
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 11, 2024
@RedYetiDev RedYetiDev added the meta Issues and PRs related to the general management of the project. label Sep 11, 2024
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6cc4d5f into nodejs:main Sep 12, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6cc4d5f

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RedYetiDev @aduh95
doc, meta: fix broken link in onboarding.md
9b28f86 
PR-URL: #54886
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@RedYetiDev @aduh95
doc, meta: fix broken link in onboarding.md
fec390e 
PR-URL: #54886
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@RedYetiDev @aduh95
doc, meta: fix broken link in onboarding.md
2b68c30 
PR-URL: #54886
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RedYetiDev @nodejs-github-bot @lpinca @UlisesGascon @aduh95 @RafaelGSS @marco-ippolito