test: move test-fs-utimes to sequential #54844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54844 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 651 651
Lines 183396 183375 -21
Branches 35795 35802 +7
=======================================
- Hits 161523 161507 -16
+ Misses 15161 15150 -11
- Partials 6712 6718 +6 |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Did you get a timeout in #37692 (comment)? Because that is what was happening in our CI and only on ppc64le. |
Yes. When I ran enough concurrently load the test timed out locally. It wasn't easy but I was able to reproduce. |
jasnell
added
the
author ready
Attempt to deal with flaky failures in CI by moving this to the sequential suite rather than the parallel suite
jasnell
force-pushed
the
move-test-fs-utimes-sequential
branch
from
21957c4 to
dc88b56
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Some tests time out due to a deadlock during process shutdown, see #52550 (comment). I think that the underlying issue is the same here. We could revert this when a fix lands. |
|
Closing this while we see if fixes to the deadlock resolve the issue |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Nov 28, 2024
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54844
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Nov 28, 2024
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54844 Refs: nodejs#54802
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Dec 1, 2024
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54844 Refs: nodejs#54802
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to deal with flaky failures in CI by moving this to the sequential suite rather than the parallel suite