test: reduce the allocation size in test-worker-arraybuffer-zerofill #54839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
RedYetiDev
reviewed
Sep 7, 2024
|
As written elsewhere I really see no reason to refactor this kind of tests to use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54839 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 651 651
Lines 183396 183396
Branches 35795 35798 +3
==========================================
- Hits 161523 161515 -8
+ Misses 15161 15159 -2
- Partials 6712 6722 +10 |
anonrig
approved these changes
Sep 7, 2024
|
The stress test looks good. |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
cleanup-test-worker-arraybuffer-zerofill
branch
from
4db976a
to
066d836
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky. Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests.
jasnell
force-pushed
the
cleanup-test-worker-arraybuffer-zerofill
branch
from
066d836
to
49d5078
Compare
jasnell
added a commit
that referenced
this pull request
Sep 12, 2024
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky. Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests. PR-URL: #54839 Refs: #52274 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in 4b2cab2 |
|
Some tests time out due to a deadlock during process shutdown, see #52550 (comment). I think that the underlying issue is the same here. We could revert/revisit this when a fix lands. |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky. Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests. PR-URL: #54839 Refs: #52274 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky. Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests. PR-URL: #54839 Refs: #52274 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky. Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests. PR-URL: #54839 Refs: #52274 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test has been flaky with timeouts in CI. This is possibly due to the repeated large allocations on the main thread. This commit reduces the allocation size and makes a number of other cleanups. The main goal is to hopefully make this test more reliable / not-flaky.
Also move the test to sequential. The frequent large allocations could be causing the test to be flaky if run parallel to other tests.
Refs: #52274
update: I realized after that it wasn't clear what was meant by "reduce the allocation size" here. The actual allocation on each iteration remains the same, but by waiting to start allocating until the worker reports the "online" event we reduce (albeit slightly) the number of allocations that are done overall. In local testing this reduced the actually number of allocation calls by a fair amount, reducing the amount of memory the test was using. Unfortunately I don't think just doing that is enough to moving the test to sequential should hopefully also help.