module: refator ESM loader for adding future synchronous hooks #54769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
joyeecheung
commented
Sep 4, 2024
| const wrap = FunctionPrototypeCall(translator, this, responseURL, source, isMain); | ||
| assert(wrap instanceof ModuleWrap); // No asynchronous translators should be called. | ||
| const wrap = this.#translate(url, finalFormat, source, isMain); | ||
| assert(wrap instanceof ModuleWrap, `Translator used for require(${url}) should not be async`); |
There was a problem hiding this comment.
The assertions for translators could be removed if we just switch to compiled = new WebAssembly.Module(source) in the wasm translator, though I am not sure if anyone still wants to keep the imported wasm asynchronously compiled (import 'wasm' is not really all that useful after https://github.com/WebAssembly/esm-integration/blob/main/proposals/esm-integration/README.md is shipped by V8 anyway)
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54769 +/- ##
==========================================
+ Coverage 88.06% 88.07% +0.01%
==========================================
Files 652 652
Lines 183545 183653 +108
Branches 35866 35860 -6
==========================================
+ Hits 161639 161758 +119
+ Misses 15150 15140 -10
+ Partials 6756 6755 -1
|
|
nit: refator->refactor in commit |
Qard
approved these changes
Sep 5, 2024
jasnell
approved these changes
Sep 5, 2024
joyeecheung
force-pushed
the
sync-hooks-base
branch
from
ac8f96b
to
8762ce7
Compare
|
Fixed the typo commit message - also I noticed there are a few typos in the return type of the JSDocs of |
github-actions
bot
removed
the
request-ci
jsumners-nr
approved these changes
Sep 9, 2024
github-actions
bot
removed
the
request-ci
This lays the foundation for supporting synchronous hooks proposed in nodejs/loaders#198 for ESM. - Corrects and adds several JSDoc comments for internal functions of the ESM loader, as well as explaining how require() for import CJS work in the special resolve/load paths. This doesn't consolidate it with import in require(esm) yet due to caching differences, which is left as a TODO. - The moduleProvider passed into ModuleJob is replaced as moduleOrModulePromise, we call the translators directly in the ESM loader and verify it right after loading for clarity. - Reuse a few refactored out helpers for require(esm) in getModuleJobForRequire().
joyeecheung
force-pushed
the
sync-hooks-base
branch
from
8762ce7
to
5ecaf9c
Compare
|
Rebased to resolve the merge conflicts. |
github-actions
bot
removed
the
request-ci
Qard
approved these changes
Sep 17, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3ac5b49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the foundation for supporting synchronous hooks proposed in nodejs/loaders#198 for ESM.