test: improve output of child process utilities #54622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display command and options when it fails - Keep the caller line at the top of the stack trace.
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54622 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 649 649
Lines 182562 182602 +40
Branches 35023 35037 +14
=======================================
+ Hits 159451 159494 +43
+ Misses 16396 16386 -10
- Partials 6715 6722 +7 |
anonrig
approved these changes
Aug 29, 2024
atlowChemi
approved these changes
Aug 29, 2024
github-actions
bot
removed
the
request-ci
atlowChemi
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0b120af |
sendoru
pushed a commit
to sendoru/node
that referenced
this pull request
Sep 1, 2024
- Display command and options when it fails - Keep the caller line at the top of the stack trace. PR-URL: nodejs#54622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
- Display command and options when it fails - Keep the caller line at the top of the stack trace. PR-URL: #54622 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output (just modified the expected stderr to something it's not):
Before:
After: