Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move more zlib tests to node:test #54609

Merged
merged 1 commit into from
Sep 1, 2024
Merged

test: move more zlib tests to node:test #54609

merged 1 commit into from
Sep 1, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 28, 2024

Moving zlib tests to use node:test

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (4f14eb1) to head (af7fd9a).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54609      +/-   ##
==========================================
- Coverage   87.34%   87.30%   -0.04%     
==========================================
  Files         649      649              
  Lines      182562   182755     +193     
  Branches    35023    35044      +21     
==========================================
+ Hits       159451   159561     +110     
- Misses      16396    16465      +69     
- Partials     6715     6729      +14

see 45 files with indirect coverage changes

@RedYetiDev RedYetiDev added the zlib Issues and PRs related to the zlib subsystem. label Aug 28, 2024
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 29, 2024
@anonrig anonrig force-pushed the yagiz/zlib-tests-node-test branch 3 times, most recently from bdd2e1e to 749198f Compare August 29, 2024 14:07
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61660/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61668/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61678/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61714/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61743/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61759/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61762/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 826b753 into nodejs:main Sep 1, 2024
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 826b753

sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
@anonrig @sendoru
test: move more zlib tests to node:test
23e6ce5 
PR-URL: nodejs#54609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig @aduh95
test: move more zlib tests to node:test
67e30de 
PR-URL: #54609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @jasnell @atlowChemi @RedYetiDev