Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: remove StringPrototypeCharCodeAt from posix.extname #54546

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Aug 24, 2024

Benchmark shows an improvement:

                                                                                confidence improvement accuracy (*)   (**)   (***)
path/extname-posix.js n=100000 path=''                                                  *      5.10 %       ±4.68% ±6.23%  ±8.14%
path/extname-posix.js n=100000 path='/'                                                 *      4.92 %       ±3.78% ±5.04%  ±6.55%
path/extname-posix.js n=100000 path='/foo'                                              *      6.57 %       ±6.24% ±8.32% ±10.88%
path/extname-posix.js n=100000 path='/foo/bar/baz/asdf/quux.foobarbazasdfquux'        ***      7.94 %       ±2.34% ±3.12%  ±4.08%
path/extname-posix.js n=100000 path='/foo/bar/baz/asdf/quux'                            *      5.77 %       ±4.68% ±6.24%  ±8.15%
path/extname-posix.js n=100000 path='foo/.bar.baz'                                      *      4.49 %       ±4.40% ±5.88%  ±7.69%
path/extname-posix.js n=100000 path='foo/bar/...baz.quux'                             ***     11.69 %       ±6.29% ±8.37% ±10.90%
path/extname-posix.js n=100000 path='foo/bar/..baz.quux'                               **      7.95 %       ±5.30% ±7.05%  ±9.17%
path/extname-posix.js n=100000 path='index.html'                                        *      6.52 %       ±5.33% ±7.10%  ±9.28%
path/extname-posix.js n=100000 path='index'                                                    3.09 %       ±3.90% ±5.19%  ±6.78%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 10 comparisons, you can thus
expect the following amount of false-positive results:
  0.50 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.10 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)                                                                                                                              

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Aug 24, 2024
@RedYetiDev RedYetiDev added the needs-benchmark-ci PR that need a benchmark CI run. label Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (4e68b54) to head (6fb659b).
Report is 172 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54546   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         649      649           
  Lines      182602   182602           
  Branches    35035    35037    +2     
=======================================
+ Hits       159469   159475    +6     
+ Misses      16403    16397    -6     
  Partials     6730     6730           
Files with missing lines Coverage Δ
lib/path.js 95.17% <100.00%> (ø)

... and 21 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 31, 2024

  • Passing CI
  • Approvals

Is this good-to-go? (It may need a benchmark CI tho)

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Sep 3, 2024

A benchmark CI is needed for this to land IIRC.

@nodejs-github-bot
Copy link
Collaborator

@RedYetiDev
Copy link
Member Author

The latest CI passed (wow!) - author ready?

@anonrig
Copy link
Member

anonrig commented Sep 10, 2024

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 94a457a into nodejs:main Sep 10, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 94a457a

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
PR-URL: #54546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
PR-URL: #54546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
PR-URL: #54546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants