src: remove redundant AESCipherMode #54438

tniessen · 2024-08-18T10:06:56Z

For each supported variant of AES, we already have OpenSSL's associated NID, so we can simply retrieve the block cipher mode of operation from the NID.

nodejs-github-bot · 2024-08-18T10:07:01Z

Review requested:

@nodejs/crypto

codecov · 2024-08-18T11:38:20Z

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (e4f61de) to head (976ad25).
Report is 61 commits behind head on main.

Files	Patch %	Lines
src/crypto/crypto_aes.cc	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54438   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         648      648           
  Lines      182321   182322    +1     
  Branches    34971    34977    +6     
=======================================
+ Hits       159222   159229    +7     
+ Misses      16374    16371    -3     
+ Partials     6725     6722    -3

Files	Coverage Δ
src/crypto/crypto_aes.h	`33.33% <ø> (ø)`
src/crypto/crypto_aes.cc	`52.33% <62.50%> (+0.15%)`	⬆️

... and 20 files with indirect coverage changes

tniessen · 2024-08-20T21:29:42Z

None of the test failures seem related. But it's hard to believe that our CI is in such a bad state.

nodejs-github-bot · 2024-08-26T11:02:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61480/

tniessen · 2024-08-26T11:55:38Z

The 10th CI run failed with this error:

13:04:49 Warning: Permanently added '67.158.54.159' (ED25519) to the list of known hosts.
13:04:49 remote: fatal: no such ref: jenkins-node-test-commit-windows-fanned-976ad25cdc982f96d20ef1e9267112db67e8ab39        
13:04:49 remote: git upload-archive: archiver died with error
13:04:50 fatal: sent error to the client: git upload-archive: archiver died with error
13:04:50 + git archive --format=tar --remote=binary_tmp@67.158.54.159:binary_tmp.git jenkins-node-test-commit-windows-fanned-976ad25cdc982f96d20ef1e9267112db67e8ab39 src/node_version.h -o node_version.h.tar
13:04:50 Warning: Permanently added '67.158.54.159' (ED25519) to the list of known hosts.
13:04:50 remote: fatal: no such ref: jenkins-node-test-commit-windows-fanned-976ad25cdc982f96d20ef1e9267112db67e8ab39        
13:04:50 remote: git upload-archive: archiver died with error
13:04:50 fatal: sent error to the client: git upload-archive: archiver died with error

nodejs-github-bot · 2024-08-26T15:14:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61499/

nodejs-github-bot · 2024-08-27T08:17:23Z

Landed in 74ea78d

For each supported variant of AES, we already have OpenSSL's associated NID, so we can simply retrieve the block cipher mode of operation from the NID. PR-URL: #54438 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

src: remove redundant AESCipherMode

976ad25

For each supported variant of AES, we already have OpenSSL's associated NID, so we can simply retrieve the block cipher mode of operation from the NID.

tniessen added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Aug 18, 2024

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 18, 2024

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024