Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 12.8.374.22 #54435

Closed
wants to merge 0 commits into from
Closed

deps: patch V8 to 12.8.374.22 #54435

wants to merge 0 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Aug 18, 2024 •
edited
Loading

This is an automated patch update of V8 to 12.8.374.22.

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 18, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 18, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61193/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6140/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6140/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6140/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61409/

@nodejs-github-bot nodejs-github-bot changed the title deps: patch V8 to 12.8.374.16 deps: patch V8 to 12.8.374.22 Aug 25, 2024
@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 25, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61470/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6153/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6153/

@nodejs-github-bot
Copy link
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6153/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61561/

@nodejs-github-bot nodejs-github-bot deleted the actions/update-v8-patch branch September 1, 2024 00:36
@targos
Copy link
Member

targos commented Sep 1, 2024

This was closed because the update script failed with a zero exit code: https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967

Run ./tools/dep_updaters/update-v8-patch.sh > temp-output
Error: spawn git ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:1[9](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:10))
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn git',
  path: 'git',
  spawnargs: [ 'fetch', 'origin' ]
}
✖ Do minor update to [12](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:13).8.374.26 [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ Minor V8 update [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess
All done!

@targos
Copy link
Member

targos commented Sep 1, 2024

I opened nodejs/node-core-utils#850

@targos targos restored the actions/update-v8-patch branch September 1, 2024 07:32
targos pushed a commit to targos/node that referenced this pull request Sep 1, 2024
@nodejs-github-bot @targos
deps: patch V8 to 12.8.374.22
0c771c3 
Refs: v8/v8@12.8.374.13...12.8.374.22

PR-URL: nodejs#54435
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targos
Copy link
Member

targos commented Sep 1, 2024 •
edited
Loading

Landed in 0c771c3 (CI was green before the workflow deleted the branch).

@aduh95
Copy link
Contributor

aduh95 commented Sep 12, 2024

Should this be marked as dont-land?

@targos
Copy link
Member

targos commented Sep 12, 2024

Yes, on all release lines

@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 12, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@nodejs-github-bot @louwers
deps: patch V8 to 12.8.374.22
e3766b9 
Refs: v8/v8@12.8.374.13...12.8.374.22

PR-URL: nodejs#54435
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@nodejs-github-bot @tpoisseau
deps: patch V8 to 12.8.374.22
68b045c 
Refs: v8/v8@12.8.374.13...12.8.374.22

PR-URL: nodejs#54435
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nodejs-github-bot @targos @aduh95 @jasnell @lpinca @gengjiawen @RafaelGSS @marco-ippolito