doc: explicit about VS 2015 support in readme #5406
Conversation
mscdex
added
doc
|
Is the 2015 thing called "for Windows Desktop"? |
|
@nodejs/platform-windows any input on clarifying exactly what's supported would be helpful |
Yep. https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx#scrum |
|
Visual Studio 2013 & 2015, all editions including the Community edition. |
| @@ -160,8 +160,8 @@ $ node -e "console.log('Hello from Node.js ' + process.version)" | |||
| Prerequisites: | |||
|
|
|||
| * [Python 2.6 or 2.7](https://www.python.org/downloads/) | |||
| * Visual Studio 2013 for Windows Desktop, or | |||
| * Visual Studio Express 2013 for Windows Desktop | |||
| * Visual Studio 2013 / 2015 for Windows Desktop, or | |||
There was a problem hiding this comment.
The full edition doesn't have a "for Windows Desktop" SKU. Only the Visual Studio Express does and it was called "for Windows Desktop" in 2013 and "for Desktop" in 2015.
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.
phillipj
force-pushed
the
readme-vs2015
branch
from
4afa7c9
to
6cf958e
Compare
|
@orangemocha just pushed an updated. Would you agree we can combine the express editions into one line of "for Desktop", rather than having two different lines just to get "for Windows Desktop" for VS Express 2013? |
|
Seems clear enough to me, but would like to get another +1. LGTM |
|
lgtm |
|
landed @ 1d7c370, thanks @phillipj! |
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: #5406 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org>
vcbuild.batalready supports both Visual Studio 2013 and 2015. Lets be explicit about it to avoid devs installing an old IDE.