Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update mk-ca-bundle.pl to 4fab113 #53961

Closed
wants to merge 1 commit into from

Conversation

RedYetiDev
Copy link
Member

Ref: https://github.com/curl/curl/blob/4fab113d4eb1a03f41e35616bb00d2db0927b53a/scripts/mk-ca-bundle.pl

This PR updates mk-ca-bundle.pl to the latest version provided from the cURL library.

@nodejs-github-bot nodejs-github-bot added openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory. labels Jul 19, 2024
@richardlau
Copy link
Member

Have you tested this? We've made customizations to the script over the years and a drop in replacement is unlikely to produce the same results.

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Jul 19, 2024

I saw some of the customizations, but I assumed that the script would function mostly the same. The purpose is for the script to generate CA bundle, and don’t they all follow the same spec?

Even if changes were made, wouldn't cURLs be the standard for generation?

(side note this was supposed to be a draft)

@RedYetiDev RedYetiDev marked this pull request as draft July 19, 2024 23:28
@RedYetiDev RedYetiDev closed this Jul 19, 2024
@RedYetiDev RedYetiDev reopened this Jul 19, 2024
@RedYetiDev
Copy link
Member Author

I'm gonna close this for now, and let my other PRs land before opening some new ones... I have a decent amount currently open...

@RedYetiDev RedYetiDev closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants