build: update cpplint to 1.6.1 #53960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
|
CC @nodejs/linting @nodejs/cpp-reviewers |
This was referenced Jul 19, 2024
lemire
approved these changes
Jul 20, 2024
|
We float some patches, see https://github.com/nodejs/node/commits/main/tools/cpplint.py. Also, it seems we are already using version 1.6.1, see 40d8b36. |
|
Haha! You are right, we are already on v1.6.1. Just hosted locally. Closing. sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53955
This PR updates
cpplintto version1.6.1. The previous version used in this project had not been updated for over seven years and lacked the latest utilities. The following changes have been made:cpplintis now retrieved from PyPI instead of being stored locally.tools/cpplint.pyhas been removed because the file itself was removed. This is what has been done with other linters (e.g., Python, YAML).Additionally, this version introduces the
build/include_ordercheck, which is currently disabled viaCPPLINT.cfg(formerly.cpplint). This check enforces the following import order:<filename>.h)This check can be re-enabled if needed.