Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: reword linter messages #53949

Merged
merged 1 commit into from
Jul 21, 2024
Merged

meta: reword linter messages #53949

merged 1 commit into from
Jul 21, 2024

Conversation

RedYetiDev
Copy link
Member

This PR rewords the eslint messages to uniformly include only formal language (I.E. No 'We').

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 19, 2024
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev requested a review from aduh95 July 19, 2024 16:12
eslint.config.mjs Outdated Show resolved Hide resolved
@RedYetiDev
Copy link
Member Author

I made the suggestions, added . periods, and fixed the message for module, as it is importable.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 19, 2024
@aduh95 aduh95 merged commit e8c2acf into nodejs:main Jul 21, 2024
21 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jul 21, 2024

Landed in e8c2acf

targos pushed a commit that referenced this pull request Jul 28, 2024
PR-URL: #53949
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #53949
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants