lib: disallow destructuring internalBinding output

[anonrig]

I'd be happy if someone could takeover this pull request.

[RedYetiDev]

For reference, this caused the fs crashing issue in #53902.

[anonrig]

@RedYetiDev would you be interested in taking over this PR?

[RedYetiDev]

I'd love to, but I don't have the time. If it still needs to be taken over in 2 weeks, I'll be able to.

Thanks for the offer ❤️

[Ceres6]

Hello!

I'd be happy to help. I'm guessing this is missing changing all the desctructuring of internal bindings and making tests pass, am I right?

[anonrig]

Hello!

I'd be happy to help. I'm guessing this is missing changing all the desctructuring of internal bindings and making tests pass, am I right?

True.

[Ceres6]

I'm a bit rusty on the workflow to continue with your PR. I'd say checkout your branch -> push to my own fork -> PR to your branch, or is there a better way?

[anonrig]

I'm a bit rusty on the workflow to continue with your PR. I'd say checkout your branch -> push to my own fork -> PR to your branch, or is there a better way?

Just take the changes in this PR and push it to your branch. No need to push to my fork.

[Ceres6]

Should I create a new PR then?

Also not sure if I need to create an interface for each internalBinding that was destructured like the one in typings/internalBinding/heap_utils.d.ts

[anonrig]

Should I create a new PR then?

Also not sure if I need to create an interface for each internalBinding that was destructured like the one in typings/internalBinding/heap_utils.d.ts

That's a nice to have. You can open a new PR.

[Ceres6]

Follow up PR opened

[anonrig]

Closing on favor of #54023