-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: disallow destructuring internalBinding output #53947
lib: disallow destructuring internalBinding output #53947
Conversation
For reference, this caused the |
@RedYetiDev would you be interested in taking over this PR? |
I'd love to, but I don't have the time. If it still needs to be taken over in 2 weeks, I'll be able to. Thanks for the offer ❤️ |
Hello! I'd be happy to help. I'm guessing this is missing changing all the desctructuring of internal bindings and making tests pass, am I right? |
True. |
I'm a bit rusty on the workflow to continue with your PR. I'd say checkout your branch -> push to my own fork -> PR to your branch, or is there a better way? |
Just take the changes in this PR and push it to your branch. No need to push to my fork. |
Should I create a new PR then? Also not sure if I need to create an interface for each |
That's a nice to have. You can open a new PR. |
Follow up PR opened |
Closing on favor of #54023 |
I'd be happy if someone could takeover this pull request.