Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, sqlite: add --experimental-sqlite note #53907

Merged
merged 4 commits into from
Jul 19, 2024
Merged

doc, sqlite: add --experimental-sqlite note #53907

merged 4 commits into from
Jul 19, 2024

Conversation

avivkeller
Copy link
Member

Fixes #53906

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. labels Jul 17, 2024
avivkeller
avivkeller commented Jul 17, 2024
View reviewed changes
doc/api/sqlite.md Outdated Show resolved Hide resolved
@avivkeller
Copy link
Member Author

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.

@aduh95
Copy link
Contributor

aduh95 commented Jul 18, 2024

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.

Even if nodejs/core-validate-commit#121 had landed, we'd want doc: for the subsystem here

aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
doc/api/sqlite.md Outdated Show resolved Hide resolved
@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 18, 2024
@avivkeller avivkeller requested a review from aduh95 July 18, 2024 19:25
aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
doc/api/sqlite.md Outdated Show resolved Hide resolved
@avivkeller @aduh95
Update doc/api/sqlite.md
4301043 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6fc0218 into nodejs:main Jul 19, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6fc0218

targos pushed a commit that referenced this pull request Jul 28, 2024
@avivkeller @targos
doc: add --experimental-sqlite note
8bf9960 
PR-URL: #53907
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
@lheckemann
Copy link

This doesn't seem to be showing on https://nodejs.org/docs/latest-v23.x/api/sqlite.html -- is something wrong, or am I misunderstanding where it should be?

@aduh95
Copy link
Contributor

aduh95 commented Dec 26, 2024

@lheckemann SQLite integration was unflagged in #55890, which has landed on latest v23.x. The note is showing on older v23.x releases, e.g. https://nodejs.org/docs/v23.0.0/api/sqlite.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@aduh95 aduh95 aduh95 approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document that using node:sqlite requires --experimental-sqlite flag
7 participants
@avivkeller @aduh95 @nodejs-github-bot @lheckemann @H4ad @atlowChemi @targos